pySCG 707 180 2 GitHub #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Helge Wehder <[email protected]>
Signed-off-by: Helge Wehder <[email protected]>
Signed-off-by: Helge Wehder <[email protected]>
Contributor
|
Reviewing this. |
andrew-costello
approved these changes
Apr 8, 2025
Contributor
andrew-costello
left a comment
andrew-costello
left a comment
There was a problem hiding this comment.
Everything looks good to me, +1.
Contributor
|
Also reviewing this. |
s19110
reviewed
Apr 10, 2025
Contributor
s19110
left a comment
s19110
left a comment
There was a problem hiding this comment.
I left a few minor change suggestions.
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: myteron <[email protected]>
Signed-off-by: Helge Wehder <[email protected]>
s19110
approved these changes
Apr 17, 2025
Contributor
s19110
left a comment
s19110
left a comment
There was a problem hiding this comment.
Found one uppercase in Unicode. Other than that, the rule looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding #180 as per #531